gnodet commented on code in PR #26845:
URL: https://github.com/apache/camel/pull/26845#discussion_r4114674530
##########
components/camel-jdbc/src/main/docs/jdbc-component.adoc:
##########
@@ -336,3 +336,19 @@ from("timer://MoveNewCustomersEveryHour?period=3600000")
.setBody(simple("insert into processed_customer
values('${body[ID]}','${body[NAME]}')"))
.to("jdbc:testdb");
----
+
+== Secret Rotation
+
+The JDBC component implements `SecretRotationAware`. When a secret rotation
event is triggered
+(e.g. by a vault provider), the component evicts stale connections from the
component-level
+DataSource's connection pool so that new connections are created with the
updated credentials.
Review Comment:
Fixed in cc0bb0fe070c. Both jdbc-component.adoc and sql-component.adoc
(source + catalog copies) rewritten: removed the misleading "so that new
connections are created with the updated credentials" and "will pick up the new
credentials" claims. Now accurately describes the scope (component + endpoint
DataSources) and the HikariCP-only limitation. Quarkus Agroal is explicitly
called out as not supported.
##########
components/camel-sql/src/main/java/org/apache/camel/component/sql/SqlComponent.java:
##########
@@ -151,6 +153,11 @@ protected Endpoint createEndpoint(String uri, String
remaining, Map<String, Obje
return endpoint;
}
+ @Override
+ public void onSecretRotation(Object source) throws Exception {
Review Comment:
Docs updated in cc0bb0fe070c — the credential refresh limitation wording now
aligns with the IMPORTANT note across all four doc copies (jdbc/sql source +
catalog).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
