gnodet commented on PR #26845: URL: https://github.com/apache/camel/pull/26845#issuecomment-5854370697
Addressed the remaining findings from davsclaus's review in b796416a9282: **Tests** — Added a real `HikariDataSource` + h2 integration test (`DataSourceHelperHikariIntegrationTest` in camel-sql) covering both the started-pool path (`softEvictConnections()` succeeds) and the not-started-pool path (null MXBean handled gracefully). Removed the duplicate `DataSourceHelper`-level stub tests from camel-jdbc — the helper is tested once in camel-sql (both stub and real HikariCP), while camel-jdbc keeps only the `JdbcComponent`-specific tests. **`camel-support` location** — `DataSourceHelper` is intentionally in `camel-support` because it's a reflection-only utility with no compile-time dependency on HikariCP or any specific pool. It works via `javax.sql.DataSource` + reflection. Moving it to camel-jdbc or camel-sql would create a cross-module dependency (the other module would need to depend on the one hosting it). `camel-support` already hosts similar shared utilities (`CamelContextHelper`, `PropertyBindingSupport`, etc.) that serve multiple components. If it later grows vendor-specific code beyond reflection, we can revisit. **PR description** — Will update to reflect the current scope (component + endpoint DataSources, not registry scan). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
