gnodet-bot commented on code in PR #29093:
URL: https://github.com/apache/camel/pull/29093#discussion_r4466749300
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/PQCConfiguration.java:
##########
@@ -223,7 +223,8 @@ public int getSymmetricKeyLength() {
}
/**
- * The required length of the symmetric key used
+ * The required length of the symmetric key used. The default of 256 keeps
the strength of the shared secret the KEM
+ * produces; the fixed-size ciphers, such as SEED and SM4, only accept 128.
Review Comment:
📝 **Doc consistency:** `PQCDataFormat.java` and all generated schema
descriptors correctly state *"GOST3412_2015 and CHACHA7539 only accept 256"*,
but this Javadoc only mentions the 128-only side. Add the 256-only constraint
symmetrically:
```suggestion
* The required length of the symmetric key used. The default of 256
keeps the strength of the shared secret the KEM
* produces; the fixed-size ciphers, such as SEED and SM4, only accept
128; GOST3412_2015 and CHACHA7539 only accept 256.
```
##########
components/camel-pqc/src/main/docs/pqc-dataformat.adoc:
##########
@@ -127,8 +127,8 @@ YAML::
|symmetricKeyLength
|int
-|128
-|Length of the symmetric key in bits (128, 192, or 256 for AES)
+|256
Review Comment:
📝 **Doc consistency:** `CHACHA7539` also only accepts 256 (documented in
`@Metadata` and all generated model files), but this table description omits it:
```suggestion
|Length of the symmetric key in bits (128, 192 or 256 for AES). SEED and SM4
only accept 128, and GOST3412-2015 and CHACHA7539 only 256
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
