[
https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648092#comment-14648092
]
Ariel Weisberg commented on CASSANDRA-9894:
-------------------------------------------
Looks good to me conditional on a unit test for Columns.
In Columns when you serialize -1 for the encoding/number of columns can you add
a comment that using the unsigned varint is intentional? To someone who hasn't
been mucking with varints for a few weeks it's going to be confusing.
It would be nice to see a microbenchmark and benchmark demonstrating that the
use of BTree is a win. I am wondering how many additional instructions and
branches are hidden inside BTree that you pay for in the common case of small
Columns set. A BTree is more instructions for more cache locality, but in the
common case will there be enough columns to benefit?
> Serialize the header only once per message
> ------------------------------------------
>
> Key: CASSANDRA-9894
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9894
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Benedict
> Fix For: 3.0 beta 1
>
>
> One last improvement I'd like to do on the serialization side is that we
> currently serialize the {{SerializationHeader}} for each partition. That
> header contains the serialized columns in particular and for range queries,
> serializing that for every partition is wasted (note that it's only a problem
> for the messaging protocol as for sstable we only write the header once per
> sstable).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
