[
https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658428#comment-14658428
]
Ariel Weisberg commented on CASSANDRA-9894:
-------------------------------------------
I ran code coverage on ColumnsTest. serializeLargeSubset,
deserializeLargeSubset, serializeLargeSubsetSize all have no coverage. In
deserialize, the getDroppedColumnDefinition path never runs, although if we
unit test getDroppedColumnDefinition then maybe we don't care.
WRT to the test and what is tested. Can you use a random with a known or logged
seed for the test? It looks like randomHuge() accidentally returns an empty
ArrayList. I changed it to return the assembled list and then the test didn't
pass.
There are a couple of other methods like digest, selectOrderIterator,
getComplex, and getSimple that don't run. I get surprised pretty regularly so I
would test those as well.
> Serialize the header only once per message
> ------------------------------------------
>
> Key: CASSANDRA-9894
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9894
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Benedict
> Fix For: 3.0 beta 1
>
>
> One last improvement I'd like to do on the serialization side is that we
> currently serialize the {{SerializationHeader}} for each partition. That
> header contains the serialized columns in particular and for range queries,
> serializing that for every partition is wasted (note that it's only a problem
> for the messaging protocol as for sstable we only write the header once per
> sstable).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
