[
https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364177#comment-15364177
]
Alex Petrov commented on CASSANDRA-12035:
-----------------------------------------
I have several remarks:
* {{AbstractPrinter}} class is defined abstract, although never inherited
from and has no abstarct methods.
* namespace has been changed, so changes are a bit harder to track
I've restructured classes a bit and moved them to the original namespace.
However, what I've noticed is that StatsPrinter is not very well utilised in
{{Default}} implementations, for example, {{
data.convert2Map()}} is not called at all. Do you think it'd make sense to use
it?
You can find the updated version of the patch
[here|https://github.com/ifesdjeen/cassandra/tree/12035-trunk], please let me
know what you think.
> Structure for tpstats output (JSON, YAML)
> -----------------------------------------
>
> Key: CASSANDRA-12035
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12035
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Hiroyuki Nishi
> Assignee: Hiroyuki Nishi
> Priority: Minor
> Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json,
> tablestats_result.txt, tablestats_result.yaml, tpstats_result.json,
> tpstats_result.txt, tpstats_result.yaml
>
>
> In CASSANDRA-5977, some extra output formats such as JSON and YAML were added
> for nodetool tablestats.
> Similarly, I would like to add the output formats in nodetool tpstats.
> Also, I tried to refactor the tablestats's code about the output formats to
> integrate the existing code with my code.
> Please review the attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
