[
https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373033#comment-15373033
]
Alex Petrov commented on CASSANDRA-12035:
-----------------------------------------
[~hnishi] could you please take another look at the whole patch? I've also
refactored {{TableStats}} to extract all the logic into the corresponding
holder, and made several renames of variables in the {{TpStatsHolder}}. Also,
in {{TpStatsPrinter}} I've made the first row 30, not 25 symbols wide since
because of PerDiskMemtableFlushWriter_0 (long name) the table was a bit
shifted.
> Structure for tpstats output (JSON, YAML)
> -----------------------------------------
>
> Key: CASSANDRA-12035
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12035
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Hiroyuki Nishi
> Assignee: Hiroyuki Nishi
> Priority: Minor
> Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json,
> tablestats_result.txt, tablestats_result.yaml, tpstats_output.yaml,
> tpstats_result.json, tpstats_result.txt, tpstats_result.yaml
>
>
> In CASSANDRA-5977, some extra output formats such as JSON and YAML were added
> for nodetool tablestats.
> Similarly, I would like to add the output formats in nodetool tpstats.
> Also, I tried to refactor the tablestats's code about the output formats to
> integrate the existing code with my code.
> Please review the attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
