[
https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374756#comment-15374756
]
Alex Petrov commented on CASSANDRA-12035:
-----------------------------------------
So changes, summarised:
* {{TableStats}} and {{TpStats}} both provide {{json}} and {{yaml}}
formatters now.
* {{StatsHolder}} is now an interface implemented by {{TpStatsHolder}} and
{{TableStatsHolder}}
* {{StatsPrinter}} now holds default implementations for {{json}} and
{{yaml}} printers
* {{TableStats}} logic is moved to the corresponding holder
+1 from my side as well.
|[trunk|https://github.com/ifesdjeen/cassandra/tree/12035-trunk]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12035-trunk-testall/]|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12035-trunk-dtest/]|
> Structure for tpstats output (JSON, YAML)
> -----------------------------------------
>
> Key: CASSANDRA-12035
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12035
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Hiroyuki Nishi
> Assignee: Hiroyuki Nishi
> Priority: Minor
> Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json,
> tablestats_result.txt, tablestats_result.yaml, tpstats_output.yaml,
> tpstats_result.json, tpstats_result.txt, tpstats_result.yaml
>
>
> In CASSANDRA-5977, some extra output formats such as JSON and YAML were added
> for nodetool tablestats.
> Similarly, I would like to add the output formats in nodetool tpstats.
> Also, I tried to refactor the tablestats's code about the output formats to
> integrate the existing code with my code.
> Please review the attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
