[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383318#comment-16383318
]
Dinesh Joshi commented on CASSANDRA-14260:
------------------------------------------
[~jjirsa] your PR is a great step in the right direction. I had a few comments
on the namings -
# I would rename {{TableSizesPair}} to {{TableSizesResult}} and name the
fields {{totalSize}} and {{filteredSize}}.
# {{SnapshotDetails}} is actually storing only sizes for now. I am inclined to
call it {{SnapshotSizeDetails}}.
# I understand there is an implicit assumption that sizes are in bytes but it
would be nicer to name variables like {{sizeOnDiskBytes}}, {{trueSizeBytes}},
{{meanPartitionSizeBytes}}. It makes the unit of measurement clear. I do
realize it makes it verbose.
# For {{IndexBounds}}, what does {{upperPosition}} and {{lowerPosition}}
indicate? Is it an index? If so, should we call it {{upperIndex}} and
{{lowerIndex}}?
> Refactor pair to avoid boxing longs/ints
> ----------------------------------------
>
> Key: CASSANDRA-14260
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14260
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeff Jirsa
> Assignee: Jeff Jirsa
> Priority: Minor
> Fix For: 4.x
>
>
> We uses Pair<X,Y> all over the place, and in many cases either/both of X and
> Y are primitives (ints, longs), and we end up boxing them into Integers and
> Longs. We should have specialized versions that take primitives.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
