[ https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383762#comment-16383762 ]
Sylvain Lebresne commented on CASSANDRA-14260: ---------------------------------------------- Had a look and this lgtm in general. I'm not super inspired naming wise right now though there is good suggestions by [~djoshi3] above (one thing I'd notice is that {{trueSize}} is weird naming in the first place, so maybe {{dataSizeBytes}} instead?). Happy to not nitpick too much though, this is clearly much better than it was before imo. > Refactor pair to avoid boxing longs/ints > ---------------------------------------- > > Key: CASSANDRA-14260 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14260 > Project: Cassandra > Issue Type: Improvement > Reporter: Jeff Jirsa > Assignee: Jeff Jirsa > Priority: Minor > Fix For: 4.x > > > We uses Pair<X,Y> all over the place, and in many cases either/both of X and > Y are primitives (ints, longs), and we end up boxing them into Integers and > Longs. We should have specialized versions that take primitives. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org