[
https://issues.apache.org/jira/browse/CASSANDRA-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398785#comment-16398785
]
Benjamin Lerer commented on CASSANDRA-7622:
-------------------------------------------
I unfortunately does not have the time to review that patch but I quickly went
through it and here are my initial concerns
* Paging is a logic that always been difficult to get right as it is query
dependent and require different handling based on different options: {{LIMIT}},
{{PER PARTITION LIMIT}} , {{GROUP BY}} , ... Moreover, it seems to me that
forcing the person implementing the Virtual table to have to take care of it is
a bit risky.
* The tests covers only a minimal amount of the queries supported by normal
tables. It would be nice to have a more complete set of tests for each of the 3
types of queries: {{single partition queries}}, {{multi-partition queries}} and
{{range queries}}. With a combination of {{LIMIT}}, {{ORDER BY}}, {{PER
PARTITION LIMIT}} with and without paging.
* For paging tests I would prefer the use of {{CQLTester.executeNetWithPaging}}
with a paging size that vary to cover all the possible cases.
* It seems to me that the patch does not prevent to create MV, index or trigger
on top of virtual table
I
> Implement virtual tables
> ------------------------
>
> Key: CASSANDRA-7622
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7622
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Tupshin Harper
> Assignee: Chris Lohfink
> Priority: Major
> Fix For: 4.x
>
>
> There are a variety of reasons to want virtual tables, which would be any
> table that would be backed by an API, rather than data explicitly managed and
> stored as sstables.
> One possible use case would be to expose JMX data through CQL as a
> resurrection of CASSANDRA-3527.
> Another is a more general framework to implement the ability to expose yaml
> configuration information. So it would be an alternate approach to
> CASSANDRA-7370.
> A possible implementation would be in terms of CASSANDRA-7443, but I am not
> presupposing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
