[
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558429#comment-16558429
]
ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------
Github user iamaleksey commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205445770
--- Diff:
test/unit/org/apache/cassandra/db/streaming/CassandraStreamHeaderTest.java ---
@@ -43,8 +51,38 @@ public void serializerTest()
new
ArrayList<>(),
((CompressionMetadata) null),
0,
-
SerializationHeader.makeWithoutStats(metadata).toComponent());
+
SerializationHeader.makeWithoutStats(metadata).toComponent(),
+
metadata.id);
SerializationUtils.assertSerializationCycle(header,
CassandraStreamHeader.serializer);
}
+
+ @Test
+ public void serializerTest_FullSSTableTransfer()
+ {
+ String ddl = "CREATE TABLE tbl (k INT PRIMARY KEY, v INT)";
+ TableMetadata metadata = CreateTableStatement.parse(ddl,
"ks").build();
+
+ ComponentManifest manifest = new ComponentManifest(new
HashMap(ImmutableMap.of(Component.DATA, 100L)));
--- End diff --
No need to wrap the immutable map in a hashmap here (:
> Optimize streaming path in Cassandra
> ------------------------------------
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
> Issue Type: Improvement
> Components: Streaming and Messaging
> Reporter: Dinesh Joshi
> Assignee: Dinesh Joshi
> Priority: Major
> Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates
> unnecessary garbage and slows down the whole streaming process as some
> sstables can be transferred as a whole file rather than individual
> partitions. The objective of the ticket is to detect when a whole sstable can
> be transferred and skip the object reification. We can also use a zero-copy
> path to avoid bringing data into user-space on both sending and receiving
> side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
