[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558557#comment-16558557
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------

Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r205526764
  
    --- Diff: 
src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
    @@ -65,18 +85,43 @@ private CassandraStreamHeader(Version version, 
SSTableFormat.Type format, long e
             this.compressionInfo = compressionInfo;
             this.sstableLevel = sstableLevel;
             this.header = header;
    -
    +        this.fullStream = fullStream;
    +        this.componentManifest = componentManifest;
    +        this.firstKey = firstKey;
    +        this.tableId = tableId;
             this.size = calculateSize();
         }
     
    -    public CassandraStreamHeader(Version version, SSTableFormat.Type 
format, long estimatedKeys, List<SSTableReader.PartitionPositionBounds> 
sections, CompressionMetadata compressionMetadata, int sstableLevel, 
SerializationHeader.Component header)
    +    private CassandraStreamHeader(Version version, SSTableFormat.Type 
format, long estimatedKeys,
    --- End diff --
    
    I have cherry picked this change. Thanks!


> Optimize streaming path in Cassandra
> ------------------------------------
>
>                 Key: CASSANDRA-14556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>              Labels: Performance
>             Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to