[
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558881#comment-16558881
]
ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------
Github user iamaleksey commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205599465
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentManifest.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.db.streaming;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import com.google.common.collect.Iterators;
+
+import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+
+public final class ComponentManifest implements Iterable<Component>
+{
+ private final LinkedHashMap<Component, Long> components;
+
+ public ComponentManifest(Map<Component, Long> components)
+ {
+ this.components = new LinkedHashMap<>(components);
+ }
+
+ public long sizeOf(Component component)
+ {
+ Long size = components.get(component);
+ if (size == null)
+ throw new IllegalArgumentException("Component " + component +
" is not present in the manifest");
+ return size;
+ }
+
+ public long totalSize()
+ {
+ long totalSize = 0;
+ for (Long size : components.values())
+ totalSize += size;
+ return totalSize;
+ }
+
+ public List<Component> components()
+ {
+ return new ArrayList<>(components.keySet());
+ }
+
+ @Override
+ public boolean equals(Object o)
+ {
+ if (this == o)
+ return true;
+
+ if (!(o instanceof ComponentManifest))
+ return false;
+
+ ComponentManifest that = (ComponentManifest) o;
+ return components.equals(that.components);
+ }
+
+ @Override
+ public int hashCode()
+ {
+ return components.hashCode();
+ }
+
+ public static final IVersionedSerializer<ComponentManifest> serializer
= new IVersionedSerializer<ComponentManifest>()
+ {
+ public void serialize(ComponentManifest manifest, DataOutputPlus
out, int version) throws IOException
+ {
+ out.writeUnsignedVInt(manifest.components.size());
+ for (Map.Entry<Component, Long> entry :
manifest.components.entrySet())
+ {
+ out.writeByte(entry.getKey().type.id);
--- End diff --
FWIW, I realize that for most components this will be a bit redundant.
Technically it's sufficient to just store `component.name`, and get the full
`Component` via `Component.parse()`. If you don't like redundancy and want to
do it that way, that's perfectly fine too - I'm cool with either option.
> Optimize streaming path in Cassandra
> ------------------------------------
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
> Issue Type: Improvement
> Components: Streaming and Messaging
> Reporter: Dinesh Joshi
> Assignee: Dinesh Joshi
> Priority: Major
> Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates
> unnecessary garbage and slows down the whole streaming process as some
> sstables can be transferred as a whole file rather than individual
> partitions. The objective of the ticket is to detect when a whole sstable can
> be transferred and skip the object reification. We can also use a zero-copy
> path to avoid bringing data into user-space on both sending and receiving
> side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
