[
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558428#comment-16558428
]
ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------
Github user iamaleksey commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205445354
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
@@ -183,9 +261,26 @@ public CassandraStreamHeader deserialize(DataInputPlus
in, int version) throws I
sections.add(new
SSTableReader.PartitionPositionBounds(in.readLong(), in.readLong()));
CompressionInfo compressionInfo =
CompressionInfo.serializer.deserialize(in, version);
int sstableLevel = in.readInt();
+
SerializationHeader.Component header =
SerializationHeader.serializer.deserialize(sstableVersion, in);
- return new CassandraStreamHeader(sstableVersion, format,
estimatedKeys, sections, compressionInfo, sstableLevel, header);
+ TableId tableId = TableId.deserialize(in);
+ boolean fullStream = in.readBoolean();
+ ComponentManifest manifest = null;
+ DecoratedKey firstKey = null;
+
+ if (fullStream)
+ {
+ manifest = ComponentManifest.serializer.deserialize(in,
version);
+ ByteBuffer keyBuf = ByteBufferUtil.readWithVIntLength(in);
+ IPartitioner partitioner =
partitionerMapper.apply(tableId);
+ if (partitioner == null)
+ throw new
IllegalArgumentException(String.format("Could not determine partitioner for
tableId {}", tableId));
--- End diff --
Another instance of `String.format()` format string with `{}` instead of
`%s`, looks like.
> Optimize streaming path in Cassandra
> ------------------------------------
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
> Issue Type: Improvement
> Components: Streaming and Messaging
> Reporter: Dinesh Joshi
> Assignee: Dinesh Joshi
> Priority: Major
> Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates
> unnecessary garbage and slows down the whole streaming process as some
> sstables can be transferred as a whole file rather than individual
> partitions. The objective of the ticket is to detect when a whole sstable can
> be transferred and skip the object reification. We can also use a zero-copy
> path to avoid bringing data into user-space on both sending and receiving
> side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
