[ 
https://issues.apache.org/jira/browse/CASSANDRA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361668#comment-17361668
 ] 

Andres de la Peña commented on CASSANDRA-12519:
-----------------------------------------------

It seems the problem is caused by {{sstablelevelreset}} editing the metadata of 
temporary tables. When this happens the next call to 
{{Directories#sstableLister}} finds the validation problem. This call happens 
in the following call to {{sstableoflinerelevel}}, and it would also happen if 
we called {{sstablelevelreset}} again. The problem goes away if we modify 
{{sstablelevelreset}} to skip temporary tables, as it's done in [the proposed 
PR|https://github.com/apache/cassandra/pull/1058].

Additionally, [the PR for 
dtests|https://github.com/apache/cassandra-dtest/pull/144] cleans up the 
outstanding transactions with {{sstableutil}} just because the dtest doesn't 
have a way to get the levels of only the non-temporary sstables since it uses 
{{sstablemetadata}}, which AFAIK doesn't have a way to skip the temporary 
sstables.

I'm not familiarized with the {{lifecycle}} package so I'm not sure whether 
skipping the temporary sstables when resetting the levels is right, or whether 
the validation error that happens after changing the metadata is caused by a 
deeper problem. [~marcuse] [~stefania_alborghetti] I think you might be more 
familiarized with the related areas of the codebase, would you mind taking a 
look?

Here is a CircleCI round including 2k multiplexed runs of the failing tests:
* 
[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/573/workflows/0f933cad-d639-4a80-8e93-cebbbb1d0dca]
* 
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/573/workflows/2149e1ff-1dc8-4816-8678-a864722a228d]

> dtest failure in 
> offline_tools_test.TestOfflineTools.sstableofflinerelevel_test
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12519
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12519
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/python
>            Reporter: Sean McCarthy
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 4.0-rc2, 4.0, 3.0.x, 3.11.x, 4.x
>
>         Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure: 
> http://cassci.datastax.com/job/trunk_offheap_dtest/379/testReport/offline_tools_test/TestOfflineTools/sstableofflinerelevel_test/
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
>     testMethod()
>   File "/home/automaton/cassandra-dtest/offline_tools_test.py", line 209, in 
> sstableofflinerelevel_test
>     self.assertGreater(max(final_levels), 1)
>   File "/usr/lib/python2.7/unittest/case.py", line 942, in assertGreater
>     self.fail(self._formatMessage(msg, standardMsg))
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
>     raise self.failureException(msg)
> "1 not greater than 1
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to