[
https://issues.apache.org/jira/browse/CASSANDRA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362400#comment-17362400
]
Andres de la Peña commented on CASSANDRA-12519:
-----------------------------------------------
Thanks a lot for the detailed explanation, it's really helpful.
I have moved the cleanup of the transaction log from the dtest to the
{{sstablelevelreset}} and {{sstableoflinerelevel}} tools as suggested. I have
also modified the dtests for those tools to start the cluster after editing the
sstables, so we can be sure that the process can start after that edition. Here
are the CI runs, including 1000 multiplexer runs:
||branch||CircleCI||
|3.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/588/workflows/28ac873f-0480-4372-9924-bcbfb9da899c]|
|3.11|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/587/workflows/a06ab77f-33b4-4d2e-8e4c-f2fd9ab5fa39]|
|4.0.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/585/workflows/a53b89a3-2a50-4b69-a20b-3d674f991730],
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/585/workflows/d563226b-68b0-49fd-8d3a-80e5cfb7d8ad]|
|4.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/581/workflows/4baaa9a0-572f-4b45-81ca-3919d699d8ed],
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/581/workflows/66f1afd2-503b-4fc1-bc16-33d775d13373]|
|trunk|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/586/workflows/9267e775-a113-46c3-80a3-872999a434d8],
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/586/workflows/9c8f8253-7642-4573-b774-9941973511a4]|
Please note that the patch addresses the problem described in Berenger's
comment, but the failure about assertions on the number of levels mentioned in
the description is a different problem that is not addressed by this patch.
However that failure only affects 3.0 and 3.11. I think we should open a
followup ticket for that particular problem, which has been around for a while,
and keep this one focused on the transaction log problem that affects all
branches, including 4.0.0.
Also, now that we know what's the cause of the problem, there is the question
on whether this ticket should be a blocker for 4.0.0. The problem with the
transaction log seems to happen very rarely and, even if it happens, it doesn't
seem to have very dramatic consequences, since there is no damage to the
sstables and operators can use {{sstableutil}} to cleanup the outstanding
transactions.
> dtest failure in
> offline_tools_test.TestOfflineTools.sstableofflinerelevel_test
> -------------------------------------------------------------------------------
>
> Key: CASSANDRA-12519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12519
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Sean McCarthy
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0-rc2, 4.0, 3.0.x, 3.11.x, 4.0-rc, 4.x
>
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/379/testReport/offline_tools_test/TestOfflineTools/sstableofflinerelevel_test/
> {code}
> Stacktrace
> File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
> File "/home/automaton/cassandra-dtest/offline_tools_test.py", line 209, in
> sstableofflinerelevel_test
> self.assertGreater(max(final_levels), 1)
> File "/usr/lib/python2.7/unittest/case.py", line 942, in assertGreater
> self.fail(self._formatMessage(msg, standardMsg))
> File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "1 not greater than 1
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
