[
https://issues.apache.org/jira/browse/CASSANDRA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362950#comment-17362950
]
Andres de la Peña commented on CASSANDRA-12519:
-----------------------------------------------
{quote}+1 to the current code if those {{sstableverify}} failures existed
before the PR
{quote}
The failure in {{sstableverify}} can be seen in [this old Jenkins
run|https://ci-cassandra.apache.org/job/Cassandra-3.0/lastCompletedBuild/testReport/dtest-novnode.offline_tools_test/TestOfflineTools/test_sstableverify/].
I have also started a [run in the
multiplexer|https://app.circleci.com/pipelines/github/adelapena/cassandra/591/workflows/f42cc6fe-8ceb-4a04-ac45-10311e707e5a]
without the patch. It hasn't finished yet but the {{sstableverify}} can also
be found in the logs. Also, I think that the proposed changes in
{{sstablelevelreset}} and {{sstableoflinerelevel}} are not in the path of that
test. So I think it's safe to say that the failure is not related.
{quote}+1 to not making this a 4.0.0 blocker as we have sstableutil as a
workaround
{quote}
Being the patch ready to commit, I'm not sure whether we should commit it to
4.0.0 or not. The two changed offline tools seem quite isolated so it doesn't
seem that this is going to introduce a great risk of slowing down the release,
but at this point any risk seems very undesirable. [~bereng] should we just
exclude {{cassandra-4.0.0}} from the commit? wdyt?
[~stefania] thanks again for helping with this.
> dtest failure in
> offline_tools_test.TestOfflineTools.sstableofflinerelevel_test
> -------------------------------------------------------------------------------
>
> Key: CASSANDRA-12519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12519
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Sean McCarthy
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0-rc2, 4.0, 3.0.x, 3.11.x, 4.0-rc, 4.x
>
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/379/testReport/offline_tools_test/TestOfflineTools/sstableofflinerelevel_test/
> {code}
> Stacktrace
> File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
> File "/home/automaton/cassandra-dtest/offline_tools_test.py", line 209, in
> sstableofflinerelevel_test
> self.assertGreater(max(final_levels), 1)
> File "/usr/lib/python2.7/unittest/case.py", line 942, in assertGreater
> self.fail(self._formatMessage(msg, standardMsg))
> File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "1 not greater than 1
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
