[
https://issues.apache.org/jira/browse/CASSANDRA-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422708#comment-17422708
]
Aleksei Zotov commented on CASSANDRA-16976:
-------------------------------------------
[~stefan.miklosovic]
{quote}are these outputs ordered in same fashion?
{quote}
I have not checked that, but based on my understanding their order might be
different. VTs are sorted based on partition key and clustering columns:
{code:java}
protected final NavigableMap<DecoratedKey, Partition> partitions;
{code}
{code:java}
private final NavigableMap<Clustering<?>, Row> rows;
{code}
whereas nodetool is not additionally sorted. It is not a big deal to sort it,
but I'm wondering if there is any real benefit of doing it. There are no any
order guarantees for nodetool and VTs AFAIK, so I'm not sure having the same
order is smth really necessary. WDYT?
{quote}AbstractNetstatsStreaming
{quote}
Ok, thanks for the reference! I'll take a look.
{quote}Same holds for "progress".
{quote}
That's not smth related to my changes. But in general I agree and feel the
current logic is wrong. In fact we do not recalculate the unit based on
"total"/"progress" actual unit. Moreover, it is theoretically possible that
"total" and "progress" have different units ("total" is GiB, but "progress" is
yet MiB). I feel it makes sense to set unit to "N/A" in case of
"human-readable" output. WDYT?
> Make nodetool compactionstats and sstable_tasks consistent
> ----------------------------------------------------------
>
> Key: CASSANDRA-16976
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16976
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Virtual Tables, Tool/nodetool
> Reporter: Aleksei Zotov
> Assignee: Aleksei Zotov
> Priority: Normal
> Fix For: 4.x
>
>
> Currently there is a difference in the output if {{nodetool compactionstats}}
> command and {{sstable_tasks}} virtual table (originally introduced by
> CASSANDRA-14457). They need to be aligned. The differences are:
>
> ||nodetool||VT||Comment||
> |percentComplete|completion_ratio|column naming is different only|
> |completed|progress|column naming is different only|
> |compaction type|kind|column naming is different only|
> |sstables|NA| |
> Additionally, please, update necessary documentation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
