[
https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461596#comment-17461596
]
Andres de la Peña commented on CASSANDRA-17212:
-----------------------------------------------
{quote}Is {{guardrails}} the best namespace for these limits? The feature might
be called guardrails, but intuitively I attribute to this user/session limits
not global restrictions for e.g. reporting errors. I also think there's no
reason to separate this kind of limit from e.g. concurrency limits for reads
and writes, and other settings that are unlikely to be a part of the guardrails
framework.
{quote}
The property
[{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/95522f85d5e14734f9af3096953974a4f48a884f/conf/cassandra.yaml#L1441]
is currently in the section for safety thresholds,
[{{concurrent_reads}}|https://github.com/apache/cassandra/blob/95522f85d5e14734f9af3096953974a4f48a884f/conf/cassandra.yaml#L538],
{{{}concurrent_writes{}}}, etc. are in a different section. Those concurrency
limits are internal global limits while, if I'm right, {{minimum_keyspace_rf}}
is checked for {{CREATE KEYSPACE}} and {{ALTER KEYSPACE}} CQL statements. I
think that would make {{minimum_keyspace_rf}} a user/session limit similar to
other guardrails, like for example the one for the number of created tables.
A difference between that threshold and current guardrails is that the proposed
guardrails are always about limiting things that might degrade performance,
while {{minimum_keyspace_rf}} seems focused on redundancy. In principle I don't
see why can't we include that type of things as guardrails, but it would mean
to extend their scope.
However we might still want to keep that particular limit where it is if we
want it close to
[{{default_keyspace_rf}}|https://github.com/apache/cassandra/blob/95522f85d5e14734f9af3096953974a4f48a884f/conf/cassandra.yaml#L1436],
which doesn't seem like a candidate for guardrails, unless we want to somehow
add defaults to them.
> Migrate threshold for minimum keyspace replication factor to guardrails
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-17212
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17212
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Priority: Normal
>
> The config property
> [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml]
> that was added by CASSANDRA-14557 can be migrated to guardrails, for example:
> {code}
> guardrails:
> ...
> replication_factor:
> warn_threshold: 2
> abort_threshold: 3
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
