[ 
https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477823#comment-17477823
 ] 

Andres de la Peña commented on CASSANDRA-17212:
-----------------------------------------------

[~benedict] sorry for the late response, I missed this right before holidays.

Guardrails are meant to be optional safety limits replacing most of what is in 
the [{{SAFETY 
THRESHOLDS}}|https://github.com/apache/cassandra/blob/96c80f0b89314dc805714c52dcf1846491c53cdc/conf/cassandra.yaml#L1358-L1360]
 section that was added to {{cassandra.yaml}} by CASSANDRA-11529. I understand 
that the criteria to decide whether a limit is classified as a guardrail is the 
optional nature of guardrails: you don't strictly need them, but they allow to 
run the cluster more safely. I guess the yaml will be a bit confusing until we 
have finished to migrate relevant limits to guardrails, which hopefully 
shouldn't take that long.

Guardrails are nested under the {{guardrails}} section on {{cassandra.yaml}} so 
we can globally enable/disable them with the 
[{{guardrails.enabled}}|https://github.com/apache/cassandra/blob/96c80f0b89314dc805714c52dcf1846491c53cdc/conf/cassandra.yaml#L1587-L1588]
 config property. I wouldn't be against changing the name to something perhaps 
more self descriptive such as {{safety_limits}} or something like that, but I 
think that nesting them under a common key is useful for setting global 
properties such as {{{}enable{}}}, and it also helps to give some structure to 
the yaml.

CC [~dcapwell] 

> Migrate threshold for minimum keyspace replication factor to guardrails
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-17212
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17212
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Feature/Guardrails
>            Reporter: Andres de la Peña
>            Priority: Normal
>
> The config property 
> [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml]
>  that was added by CASSANDRA-14557 can be migrated to guardrails, for example:
> {code}
> guardrails:
>     ...
>     replication_factor:
>         warn_threshold: 2
>         abort_threshold: 3
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to