[
https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691101#comment-17691101
]
Michael Semb Wever commented on CASSANDRA-18258:
------------------------------------------------
bq. Yes, until then and the drop of JDK8 I guess we should say "Cassandra 5.0
requires Java 8 or Java 11". 17 is still not really supported so I guess we can
skip mentioning it for now? WDYT? Or we can add also "Java 17 experimental" or
so?
Yes to your suggestions, like (so to keep the code as close to post-18255 as
possible):
{noformat}
elif [ "$JVM_VERSION" \< "17" ] ; then
echo "Cassandra 5.0 requires Java 11 or Java 17."
#exit 1; # TODO – uncomment when CASSANDRA-18255 lands
else
echo "Java 17 is experimental in Cassandra 5.0"
fi
{noformat}
{quote}
bq. nit: regarding target name="_maybe_update_idea_to_java17"
if="java.version.17"
That is nothing more than using an equivalent to Java 11 target name but a new
one for 17, but I am open for suggestions.
{quote}
Didn't mean to imply you were encouraging anything :-)
I just don't see the purpose of having a separate IDE profile for the higher
JDK, because you have to code against the lowest supported JDK anyway. Maybe
[~bdeggleston] knows from when CASSANDRA-15108 was introduced, but I suspect it
was just added without much discussion.
bq. We need to have it with the three options so people can easily debug JDK
specific issues, no?
Good question. This code looks only to flip the language level from one jdk to
the other. Changing the runtime jdk used, and just general custom jdk17 editing
if that's what you really want, should just be done by editing the settings
manually, IMHO.
So my suggestion is to remove both {{_maybe_update_idea_to_java11}} and
{{_maybe_update_idea_to_java17}} targets and see if anyone complains…
> Add test conf for JDK17
> -----------------------
>
> Key: CASSANDRA-18258
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18258
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> Post CASSANDRA-18252 and CASSANDRA-18179 we will be able to compile current
> trunk with JDK17 but in order to start Cassandra and test it we will need
> also our conf files updated with some preliminary conf for test purposes.
> This ticket will be used to add those to current trunk
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
