5 commented on code in PR #15:
URL:
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1321848028
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/CassandraValidation.java:
##########
@@ -0,0 +1,24 @@
+package org.apache.cassandra.spark.validation;
+
+import org.apache.cassandra.sidecar.client.SidecarClient;
+import org.apache.cassandra.sidecar.common.data.HealthResponse;
+
+public class CassandraValidation implements StartupValidation
+{
+ private final SidecarClient sidecar;
+
+ public CassandraValidation(SidecarClient sidecar)
+ {
+ this.sidecar = sidecar;
+ }
+
+ @Override
+ public void validate()
+ {
+ HealthResponse health = sidecar.cassandraHealth().get();
Review Comment:
We do have two distinct endpoints in Sidecar, so I think we should call both.
It's up to Sidecar to decide what "being healthy" means for it.
Can be that Cassandra is healthy, but sidecar isn't, for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
