frankgh commented on code in PR #15:
URL:
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1321851304
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/TruststoreValidation.java:
##########
@@ -0,0 +1,22 @@
+package org.apache.cassandra.spark.validation;
+
+import org.apache.cassandra.secrets.SecretsProvider;
+
+public class TruststoreValidation implements StartupValidation
+{
+ private final SecretsProvider secrets;
+
+ public TruststoreValidation(SecretsProvider secrets)
+ {
+ this.secrets = secrets;
+ }
+
+ @Override
+ public void validate()
+ {
+ if (!secrets.hasTrustStoreSecrets())
Review Comment:
well, a truststore should be optional, if not provided the JVM will pick up
the default truststore. But if provided, we need to make sure that the keystore
is valid with the provided truststore. Errors will look like "certification
path can't be established" or something along those lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
