5 commented on code in PR #15: URL: https://github.com/apache/cassandra-analytics/pull/15#discussion_r1321850052
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/SidecarValidation.java: ########## @@ -0,0 +1,24 @@ +package org.apache.cassandra.spark.validation; + +import org.apache.cassandra.sidecar.client.SidecarClient; +import org.apache.cassandra.sidecar.common.data.HealthResponse; + +public class SidecarValidation implements StartupValidation +{ + private final SidecarClient sidecar; + + public SidecarValidation(SidecarClient sidecar) + { + this.sidecar = sidecar; + } + + @Override + public void validate() + { + HealthResponse health = sidecar.sidecarHealth().get(); Review Comment: Good point, added timeouts both here and in `CassandraValidation`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org