skoppu22 commented on code in PR #214:
URL:
https://github.com/apache/cassandra-analytics/pull/214#discussion_r3364964346
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraDirectDataTransportContext.java:
##########
@@ -46,13 +46,24 @@ public CassandraDirectDataTransportContext(@NotNull
BulkWriterContext bulkWriter
}
@Override
- public DirectStreamSession createStreamSession(BulkWriterContext
writerContext,
- String sessionId,
- SortedSSTableWriter
sstableWriter,
- Range<BigInteger> range,
-
ReplicaAwareFailureHandler<RingInstance> failureHandler,
- ExecutorService
executorService)
+ public StreamSession<TransportContext.DirectDataBulkWriterContext>
createStreamSession(
+ BulkWriterContext writerContext,
+ String sessionId,
+ SortedSSTableWriter sstableWriter,
+ Range<BigInteger> range,
+ ReplicaAwareFailureHandler<RingInstance> failureHandler,
+ ExecutorService executorService)
{
+ if (bridge().isTracked(clusterInfo.getReplicationType()))
+ {
+ return new TrackedDirectStreamSession(writerContext,
Review Comment:
As we plan to implement the feature in multiple PRs and phases, can we have
a feature flag, set to disabled by default, so the existing code doesn't get
impacted by this feature changes by any chance. And developers can turn it on
when they like to try it out. CI can enable the feature flag to test the code.
We can set it enabled by default when we reach a comfortable stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
