sarankk commented on code in PR #214:
URL:
https://github.com/apache/cassandra-analytics/pull/214#discussion_r3365185025
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraDirectDataTransportContext.java:
##########
@@ -46,13 +46,24 @@ public CassandraDirectDataTransportContext(@NotNull
BulkWriterContext bulkWriter
}
@Override
- public DirectStreamSession createStreamSession(BulkWriterContext
writerContext,
- String sessionId,
- SortedSSTableWriter
sstableWriter,
- Range<BigInteger> range,
-
ReplicaAwareFailureHandler<RingInstance> failureHandler,
- ExecutorService
executorService)
+ public StreamSession<TransportContext.DirectDataBulkWriterContext>
createStreamSession(
+ BulkWriterContext writerContext,
+ String sessionId,
+ SortedSSTableWriter sstableWriter,
+ Range<BigInteger> range,
+ ReplicaAwareFailureHandler<RingInstance> failureHandler,
+ ExecutorService executorService)
{
+ if (bridge().isTracked(clusterInfo.getReplicationType()))
+ {
+ return new TrackedDirectStreamSession(writerContext,
Review Comment:
The tracked stream session should not be used for existing use cases since
keyspace would not be tracked and we cannot use direct stream session when
keyspace is tracked. Hence feature flag might not be necessary here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
