skoppu22 commented on code in PR #214:
URL:
https://github.com/apache/cassandra-analytics/pull/214#discussion_r3365115916
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/CqlUtilsTest.java:
##########
@@ -833,6 +833,43 @@ public void testTimeRangeFilterSupported()
assertThat(isTimeRangeFilterSupported("")).isFalse();
}
+ @Test
+ public void testExtractReplicationType()
+ {
+ String schemaStrTracked
+ = "CREATE KEYSPACE k WITH REPLICATION "
+ + "= { 'class' :
'org.apache.cassandra.locator.NetworkTopologyStrategy', 'dc1': '3' }"
+ + " AND DURABLE_WRITES = true AND replication_type = 'tracked';";
+ assertThat(CqlUtils.extractReplicationType(schemaStrTracked,
"k")).isEqualTo("tracked");
+ String schemaStrTrackedCaseInsensitive
Review Comment:
For better readability, can you please either create separate tests for
these or separate them with new lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
