skoppu22 commented on code in PR #214:
URL:
https://github.com/apache/cassandra-analytics/pull/214#discussion_r3365153253
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfoTest.java:
##########
@@ -75,6 +77,50 @@ public static CassandraClusterInfo
mockClusterInfoForTimeSkewTest(int allowanceM
return new MockClusterInfoForTimeSkew(allowanceMinutes, remoteNow);
}
+ @Test
+ void testGetTrackedReplicationType()
+ {
+ String schema = "CREATE KEYSPACE mykeyspace "
+ + "WITH replication = {'class':
'NetworkTopologyStrategy', 'dc1': '3'}"
+ + " AND durable_writes = true"
+ + " AND replication_type = 'tracked';";
+ CassandraClusterInfo ci = mockClusterInfoWithSchema("mykeyspace",
schema);
+ assertThat(ci.getReplicationType())
Review Comment:
These tests are not testing changes to CassandraClusterInfo, because
MockClusterInfoForSchema overriding getReplicationType to call CqlUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
