DK101010 commented on a change in pull request #4630:
URL: https://github.com/apache/cloudstack/pull/4630#discussion_r569365918
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +140,10 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+ if(vm.getVirtualMachine() instanceof VMInstanceVO){
+ VMInstanceVO vmInstanceVO =(VMInstanceVO)
vm.getVirtualMachine();
+
to.setEnableDynamicallyScaleVm(vmInstanceVO.isDynamicallyScalable());
Review comment:
> HypervisorGuruBase is already setting this paramter in
toVirtualMachineTO(), can you please double check if this is necessary or
redundant in VmwareVMImplementer.
> to.setEnableDynamicallyScaleVm(isDynamicallyScalable);
@harikrishna-patnala Hmm ... during my test I could enable/disable the flag
in the fronend but in backend it keeps of false. That is the reason for my
implementation in VmwareVmImplementer.java
I have checked the HypervisorGuru and found follow line
`Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable() &&
UserVmManager.EnableDynamicallyScaleVm.valueIn(vm.getDataCenterId());`
I think I understood now what do you mean with zone settings. ;) But I ask
me why we need two flags for the same thing. In my opinion it is confusing and
not handy for a user to enable two flags to use this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
