DK101010 commented on a change in pull request #4630:
URL: https://github.com/apache/cloudstack/pull/4630#discussion_r578441412
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +140,10 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+ if(vm.getVirtualMachine() instanceof VMInstanceVO){
+ VMInstanceVO vmInstanceVO =(VMInstanceVO)
vm.getVirtualMachine();
+
to.setEnableDynamicallyScaleVm(vmInstanceVO.isDynamicallyScalable());
Review comment:
@DaanHoogland Thanks for input. Good to know for the future.
@harikrishna-patnala sure, i can revert this, but I still don't find it
practical to enable 2 flags to turn a feature on ;).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
