harikrishna-patnala commented on a change in pull request #4630:
URL: https://github.com/apache/cloudstack/pull/4630#discussion_r577360515
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +140,10 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+ if(vm.getVirtualMachine() instanceof VMInstanceVO){
+ VMInstanceVO vmInstanceVO =(VMInstanceVO)
vm.getVirtualMachine();
+
to.setEnableDynamicallyScaleVm(vmInstanceVO.isDynamicallyScalable());
Review comment:
Thanks @DaanHoogland for explaining that.
Here in this case setting isDynamicallyScalable on VM has no dependency on
hypervisor type that is why HypervisorGuruBase sets the dynamic scaling flag on
VM while preparing TO (transfer object). Setting this flag in either VMwareGuru
or VMwareVMImplementer is not required.
@DK101010 I would suggest you to please revert the change HypervisorGuruBase
in which you ignored the global/zone setting. This is required because
global/zone level setting actually decides whether dynamic scaling can be
enabled in that management setup or not. vmInstance.isDynamicallyScalable() is
not sufficient. There is another PR#4643 which fixes and all these settings.
For this PR you can keep the VMwareResource changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
