harikrishna-patnala commented on a change in pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571946525
########## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ########## @@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe return vm; } + @Override + public Boolean checkIfDynamicScalingCanBeEnabled(ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) { Review comment: VM is separated because first VM deployment will not have VM flag already saved. But I felt putting a null check would simplify the code a bit. Made those changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org