sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572003114
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
return vm;
}
+ @Override
+ public boolean checkIfDynamicScalingCanBeEnabled(VirtualMachine vm,
ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
+ boolean canEnableDynamicScaling = (vm != null?
vm.isDynamicallyScalable():true) && offering.isDynamicScalingEnabled() &&
template.isDynamicallyScalable() &&
UserVmManager.EnableDynamicallyScaleVm.valueIn(zoneId);
Review comment:
format update _vm != null ? vm.isDynamicallyScalable() : true_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
