sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571999553
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2730,6 +2730,19 @@ public UserVm updateVirtualMachine(long id, String
displayName, String group, Bo
if (isDynamicallyScalable == null) {
isDynamicallyScalable = vm.isDynamicallyScalable();
+ } else {
+ if (isDynamicallyScalable == true) {
+ VMTemplateVO template =
_templateDao.findByIdIncludingRemoved(vm.getTemplateId());
+ if (!template.isDynamicallyScalable()) {
Review comment:
below checks will be missed for the updated `isDynamicallyScalable` when
"isDynamicallyScalable == null"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
