sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571992645



##########
File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
         return storagePolicy;
     }
 
+    public Boolean getDynamicScalingEnabled() {
+        return isDynamicScalingEnabled == null ? Boolean.TRUE : 
isDynamicScalingEnabled;

Review comment:
       The default value is false, for the global setting 
"_enable.dynamic.scale.vm_" and parameter "_isdynamicallyscalable_" in 
registerTemplate/ISO call , defined earlier. Any reason, to make default as 
"True" here ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to