harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572153290
##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -240,7 +239,7 @@ protected VirtualMachineTO
toVirtualMachineTO(VirtualMachineProfile vmProfile) {
// Workaround to make sure the TO has the UUID we need for Niciri
integration
VMInstanceVO vmInstance = _virtualMachineDao.findById(to.getId());
// check if XStools/VMWare tools are present in the VM and dynamic
scaling feature is enabled (per zone/global)
- Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable() &&
UserVmManager.EnableDynamicallyScaleVm.valueIn(vm.getDataCenterId());
+ Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable();
Review comment:
During VM deployment when VM entry is persisted, VM's dynamic
scalability is evaluated based on all options user input, template, service
offering and global setting. So no need to check with global setting while
preparing the transfer object.
Removing the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
