sureshanaparti commented on a change in pull request #4955:
URL: https://github.com/apache/cloudstack/pull/4955#discussion_r621174791
##########
File path:
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
##########
@@ -328,51 +318,28 @@ public boolean generateSetupCommand(Long ssHostId) {
String nfsVersion =
imageStoreDetailsUtil.getNfsVersion(ssStore.getId());
setupCmd.setNfsVersion(nfsVersion);
- //template/volume file upload key
String postUploadKey =
_configDao.getValue(Config.SSVMPSK.key());
setupCmd.setPostUploadKey(postUploadKey);
+ String debugMessage = String.format("Successfully programmed
secondary storage [%s] in secondary storage VM [%s].", ssStore.getName(),
secStorageVm.getInstanceName());
+
Answer answer = _agentMgr.easySend(ssHostId, setupCmd);
if (answer != null && answer.getResult()) {
SecStorageSetupAnswer an = (SecStorageSetupAnswer)answer;
if (an.get_dir() != null) {
- // update the parent path in image_store table for
this image store
ImageStoreVO svo =
_imageStoreDao.findById(ssStore.getId());
svo.setParent(an.get_dir());
_imageStoreDao.update(ssStore.getId(), svo);
}
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Successfully programmed secondary
storage " + ssStore.getName() + " in secondary storage VM " +
secStorageVm.getInstanceName());
- }
- } else {
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Successfully programmed secondary
storage " + ssStore.getName() + " in secondary storage VM " +
secStorageVm.getInstanceName());
- }
- return false;
- }
- }
- }
- /* After removing SecondaryStorage entries from host table, control
should never come here!!
- else if( cssHost.getType() == Host.Type.SecondaryStorage ) {
- List<SecondaryStorageVmVO> alreadyRunning =
_secStorageVmDao.getSecStorageVmListInStates(SecondaryStorageVm.Role.templateProcessor,
zoneId, State.Running);
- String secUrl = cssHost.getStorageUrl();
- SecStorageSetupCommand setupCmd = new
SecStorageSetupCommand(secUrl, null);
- for ( SecondaryStorageVmVO ssVm : alreadyRunning ) {
- HostVO host =
_resourceMgr.findHostByName(ssVm.getInstanceName());
- Answer answer = _agentMgr.easySend(host.getId(), setupCmd);
- if (answer != null && answer.getResult()) {
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Successfully programmed secondary
storage " + host.getName() + " in secondary storage VM " +
ssVm.getInstanceName());
- }
+
+ s_logger.debug(debugMessage);
} else {
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Successfully programmed secondary
storage " + host.getName() + " in secondary storage VM " +
ssVm.getInstanceName());
- }
+ s_logger.debug(debugMessage);
Review comment:
seems the logs msg here is not correct. method returns false when there
is no answer and still logging "_Successfully programmed secondary storage..._"
, check and correct log here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
