sureshanaparti commented on a change in pull request #4955:
URL: https://github.com/apache/cloudstack/pull/4955#discussion_r621187855
##########
File path:
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
##########
@@ -1272,22 +1216,20 @@ public boolean finalizeCommandsOnStart(Commands cmds,
VirtualMachineProfile prof
public boolean finalizeStart(VirtualMachineProfile profile, long hostId,
Commands cmds, ReservationContext context) {
CheckSshAnswer answer = (CheckSshAnswer)cmds.getAnswer("checkSsh");
if (!answer.getResult()) {
- s_logger.warn("Unable to ssh to the VM: " + answer.getDetails());
+ s_logger.warn(String.format("Unable to connect via SSH to the VM
[%s] due to [%s] ", profile.toString(), answer.getDetails()));
return false;
}
try {
- //get system ip and create static nat rule for the vm in case of
basic networking with EIP/ELB
Review comment:
Observed that all the comments are removed. I think these comments were
added to understand the code there, and would help in debugging sometimes. You
can remove them judiciously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
