GutoVeronezi commented on a change in pull request #4955:
URL: https://github.com/apache/cloudstack/pull/4955#discussion_r622406658
##########
File path:
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
##########
@@ -686,50 +656,41 @@ protected String connect(String ipAddress, int port) {
}
public SecondaryStorageVmVO assignSecStorageVmFromRunningPool(long
dataCenterId, SecondaryStorageVm.Role role) {
-
- if (s_logger.isTraceEnabled()) {
- s_logger.trace("Assign secondary storage vm from running pool for
request from data center : " + dataCenterId);
- }
+ s_logger.debug(String.format("Assign secondary storage VM from running
pool for request from zone [%s].", dataCenterId));
SecondaryStorageVmAllocator allocator = getCurrentAllocator();
assert (allocator != null);
List<SecondaryStorageVmVO> runningList =
_secStorageVmDao.getSecStorageVmListInStates(role, dataCenterId, State.Running);
- if (runningList != null && runningList.size() > 0) {
- if (s_logger.isTraceEnabled()) {
- s_logger.trace("Running secondary storage vm pool size : " +
runningList.size());
Review comment:
About changing the log level to debug, in this context, these messages
work better as debug; as well, it is quite unusual to call trace on ACS, so, it
is interesting to keep a pattern and use debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
