GabrielBrascher commented on a change in pull request #4955:
URL: https://github.com/apache/cloudstack/pull/4955#discussion_r623894273
##########
File path:
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
##########
@@ -402,15 +368,16 @@ public boolean generateVMSetupCommand(Long ssAHostId) {
String copyPasswd = _configDao.getValue("secstorage.copy.password");
setupCmd.setCopyPassword(copyPasswd);
setupCmd.setCopyUserName(TemplateConstants.DEFAULT_HTTP_AUTH_USER);
+
Answer answer = _agentMgr.easySend(ssAHostId, setupCmd);
if (answer != null && answer.getResult()) {
if (s_logger.isDebugEnabled()) {
- s_logger.debug("Successfully programmed http auth into " +
secStorageVm.getHostName());
+ s_logger.debug(String.format("Successfully created http auth
into secondary storage VM [%s].", hostName));
Review comment:
I agree that `programmed` can be indeed changed to something that best
describes the logged operation.
`Created` is an option, but I think that `set` fits better. Additionally, I
would replace `http` with `HTTP`.
Something as:
1. `Successfully set HTTP auth into secondary storage VM [s-123-VM]`
2. or `Successfully configured HTTP auth into secondary storage VM
[s-123-VM]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
