GutoVeronezi commented on a change in pull request #4955:
URL: https://github.com/apache/cloudstack/pull/4955#discussion_r623905804
##########
File path:
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
##########
@@ -1251,13 +1194,12 @@ public boolean finalizeCommandsOnStart(Commands cmds,
VirtualMachineProfile prof
if (controlNic == null) {
if (managementNic == null) {
- s_logger.error("Management network doesn't exist for the
secondaryStorageVm " + profile.getVirtualMachine());
+ s_logger.warn(String.format("Management network does not exist
for the secondary storage %s.", profile. toString()));
return false;
}
controlNic = managementNic;
}
- // verify ssh access on management nic for system vm running on HyperV
Review comment:
@DaanHoogland done. As the comment refers only to `if...` I thought it
would be better to only extract it. Also, I extracted as protected and added
unit tests to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
