nvazquez commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r681076778
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -549,12 +549,6 @@ public static void
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
cpuInfo.setReservation((long)cpuReservedMhz);
vmConfig.setCpuAllocation(cpuInfo);
- if (cpuSpeedMHz != cpuReservedMhz) {
Review comment:
@DK101010 I think removing these lines will cause a regression on cpu
and memory overcommit, have you tested those cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
