nvazquez commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r686490135
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -549,12 +549,6 @@ public static void
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
cpuInfo.setReservation((long)cpuReservedMhz);
vmConfig.setCpuAllocation(cpuInfo);
- if (cpuSpeedMHz != cpuReservedMhz) {
Review comment:
@DK101010 I have examined the `setBasicVmConfig(..)` method is used on:
- `VmwareResource.execute(StartCommand cmd)` -> the values set on these
removed lines are not relevant, are overridden later
(https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1995-L2005)
- `HypervisorHostHelper.createBlankVm(..)` -> possible regression at this
point: blank/worker VMs are always created with `cpuHotAdd = false` and
`memHotAdd = false`. I'm not sure how/if this would affect deployments, any
thoughts?
cc. @sureshanaparti @rhtyd @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
