sureshanaparti commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r685787678
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
##########
@@ -156,7 +156,7 @@ public void destroyVolume(String volumeEntity) {
@Override
public VirtualMachineEntity createVirtualMachine(String id, String owner,
String templateId, String hostName, String displayName, String hypervisor, int
cpu,
int speed, long memory, Long diskSize, List<String> computeTags,
List<String> rootDiskTags, Map<String, List<NicProfile>> networkNicMap,
DeploymentPlan plan,
- Long rootDiskSize, Map<String, Map<Integer, String>>
extraDhcpOptionMap, Map<Long, DiskOffering> dataDiskTemplateToDiskOfferingMap)
throws InsufficientCapacityException {
+ Long rootDiskSize, Map<String, Map<Integer, String>>
extraDhcpOptionMap, Map<Long, DiskOffering> dataDiskTemplateToDiskOfferingMap,
Long diskOfferingId, Long rootDiskOfferingId) throws
InsufficientCapacityException {
Review comment:
```suggestion
Long rootDiskSize, Map<String, Map<Integer, String>>
extraDhcpOptionMap, Map<Long, DiskOffering> dataDiskTemplateToDiskOfferingMap,
Long dataDiskOfferingId, Long rootDiskOfferingId) throws
InsufficientCapacityException {
```
Update this if the 'diskOfferingId' here is for data disk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
