sureshanaparti commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r685788356
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
##########
@@ -185,10 +185,14 @@ public VirtualMachineEntity createVirtualMachine(String
id, String owner, String
ServiceOfferingVO computeOffering =
_serviceOfferingDao.findById(vm.getId(), vm.getServiceOfferingId());
- rootDiskOfferingInfo.setDiskOffering(computeOffering);
+ DiskOfferingVO rootDiskOffering =
_diskOfferingDao.findById(rootDiskOfferingId);
+ if (rootDiskOffering == null) {
+ throw new InvalidParameterValueException("Unable to find disk
offering " + rootDiskOfferingId);
Review comment:
```suggestion
throw new InvalidParameterValueException("Unable to find root
disk offering " + rootDiskOfferingId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
