sureshanaparti commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r685789250
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
##########
@@ -200,48 +204,50 @@ public VirtualMachineEntity createVirtualMachine(String
id, String owner, String
}
}
- if (vm.getDiskOfferingId() != null) {
- DiskOfferingVO diskOffering =
_diskOfferingDao.findById(vm.getDiskOfferingId());
+ if (diskOfferingId != null) {
+ DiskOfferingVO diskOffering =
_diskOfferingDao.findById(diskOfferingId);
if (diskOffering == null) {
- throw new InvalidParameterValueException("Unable to find disk
offering " + vm.getDiskOfferingId());
+ throw new InvalidParameterValueException("Unable to find disk
offering " + diskOfferingId);
Review comment:
```suggestion
throw new InvalidParameterValueException("Unable to find
data disk offering " + dataDiskOfferingId);
```
Update to 'data' disk here if relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
