shwstppr commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r821467509



##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -792,6 +809,20 @@ public VlanIpRangeResponse 
createVlanIpRangeResponse(Class<? extends VlanIpRange
                 String[] range = ip6Range.split("-");
                 vlanResponse.setStartIpv6(range[0]);
                 vlanResponse.setEndIpv6(range[1]);
+
+                IPv6Address first = IPv6Address.fromString(range[0]);

Review comment:
       this was junk code I forgot to remove it was just logging all 
IPAddresses for the range that is added

##########
File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4024,6 +4116,13 @@ public Vlan createVlanAndPublicIpRange(final 
CreateVlanIpRangeCmd cmd) throws In
             if (endIPv6 == null && startIPv6 != null) {
                 endIPv6 = startIPv6;
             }
+
+            if (startIPv6 == null && endIPv6 == null) {

Review comment:
       removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to