shwstppr commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r841066930
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
##########
@@ -471,6 +469,40 @@ def _remove_ipv6_to_interface(self, interface, ipv6):
logging.info("IPv6 address %s not present for %s" % (ipv6, dev))
return
+ def _enable_radvd(self, dev, ipv6, dns1, dns2):
Review comment:
> @shwstppr
> I think it is unnecessary to remove and regenerate `/etc/radvd.conf`.
>
> for isolated networks, it is generated by /opt/cloud/bin/setup/common.sh
> for vpc, it is generated by /opt/cloud/bin/cs/CsVpcGuestNetwork.py
>
> we need to manage (start/stop) service `radvd` in CsRedundant.py
@weizhouapache added this because setting up radvd from common.sh won't work
in RVR case. As we discussed earlier, RVRs won't get an IPv6 in guest range
from Java code. Therefore, eth0ip6 variable will be empty in common.sh and it
won't setup radvd.
So, either we assign an IPv6 to RVRs in guest range to setup radvd with
common.sh or change common.sh code to setup radvd based on guest gateway (but
in that it won't know which VR is primary) or setup radvd for primary RVR in
CsRedundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
