shwstppr commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r821469989
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4067,21 +4166,21 @@ public Vlan createVlanAndPublicIpRange(final
CreateVlanIpRangeCmd cmd) throws In
zoneId = network.getDataCenterId();
physicalNetworkId = network.getPhysicalNetworkId();
}
- } else if (ipv6) {
+ }/* else if (ipv6) {
throw new InvalidParameterValueException("Only support IPv6 on
extending existed network");
- }
+ }*/
// Verify that zone exists
final DataCenterVO zone = _zoneDao.findById(zoneId);
if (zone == null) {
throw new InvalidParameterValueException("Unable to find zone by
id " + zoneId);
}
- if (ipv6) {
- if (network.getGuestType() != GuestType.Shared ||
zone.isSecurityGroupEnabled()) {
- throw new InvalidParameterValueException("Only support IPv6 on
extending existed share network without SG");
- }
- }
+// if (ipv6) {
Review comment:
@weizhouapache `Ipv6SubnetCapacityThreshold` holds the threshold value
for IPv6 subnets and this code adds public vlan (IPv6) range. Can you please
elaborate the check that should be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
